Fix CheckedShl/CheckedShr documentation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #57 and more: - CheckedShl was hinting that None was returned on overflow rather than on too large a rhs. - Ditto for CheckedShr. - CheckedShr documentation erroneously indicated that a left shift was going to be performed instead of a right shift.
|
Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2018
90: Fix CheckedShl/CheckedShr documentation r=cuviper a=samueltardieu Fix #57 and more: - CheckedShl was hinting that None was returned on overflow rather than on too large a rhs. - Ditto for CheckedShr. - CheckedShr documentation erroneously indicated that a left shift was going to be performed instead of a right shift. Co-authored-by: Samuel Tardieu <sam@rfc1149.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57 and more:
on too large a rhs.
going to be performed instead of a right shift.