-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use serde 0.8 #222
Use serde 0.8 #222
Conversation
The |
Hmm, since it didn't require any code change, maybe our |
We really should have at least a build test too. Can you add a line to |
Alright, the PR was split into two, see #223. I am still basing the |
Fix import serde and rational deserialization Similar to #196 for num/complex, “use serde;” needed to be removed in num/rational. Also, deserialization of `num/rational` needed to be fixed by adding type annotations. This is in response to #222 (comment) of issue #222. Also added a travis line, in response to #222 (comment). Hope it works.
I confirmed that the dual-serde works locally, but could you add another test for this? The existing test you added will grab the latest possible, so that will be some 0.8.*. After that, you can force a downgrade like |
All done, thanks for the extra requests. I finally had a reason to mess around with travis a bit. :-) |
⚡ Test exempted - status |
Use serde 0.8 I updated `bigint`, `complex`, and `rational` to use `serde 0.8`, and also fixed deserialization and the `serde` feature as such in the `rational` crate (didn't add any tests, but it compiles now). Similar to #196 for `num/complex`, “`use serde;`” needed to be removed in `num/rational`.
What is the process of getting a new version of this ( |
I just need to go through and publish each updated crate. I'll try to do that tonight. |
OK, 0.1.35 is out, enjoy! |
I updated
bigint
,complex
, andrational
to useserde 0.8
, and also fixed deserialization and theserde
feature as such in therational
crate (didn't add any tests, but it compiles now).Similar to #196 for
num/complex
, “use serde;
” needed to be removed innum/rational
.