-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onig has a dependency on onig_sys 69.7.0 in crates #165
Comments
It looks like it might just be a matter of bumping this https://github.com/rust-onig/rust-onig/blob/main/onig/Cargo.toml#L38 |
Fixed in 6.3.1: |
Thank you so much for the very fast fix! |
We aim to please. Thanks for the report btw. |
Sorry to bother with this. But using cargo vendor with one of the dependencies of one project being onig, I still get the following error
When checking on the official rust documentation of the crate, those structs don't appear I can confirm that the problem only seems to happen when you vendor dependencies. Using the normal compilation process, there doesn't seem to be any problems. |
I think the docs are just really old. The key marker here is the Python syntax. That is in the latest version on docs.rs: https://docs.rs/onig_sys/69.7.1/onig_sys/static.OnigSyntaxPython.html |
I don’t know about how vendoring works. Are you using 69.7.1 of onig_sys? |
On closer inspection it looks like your error is to do with the version of oniguruma (the native library) you’re compiling against. You could try either updating that, or switching to use the built-in copy of Oniguruma: https://github.com/rust-onig/rust-onig#build-errors-caused-by-libclangllvm |
wow thank you for this! You are right, the oniguruma is one version behind! |
ref
in the dependencies part on the left it says that onig_sys should be 69.7.0 (instead of 69.7.1)
This causes compilation problems when trying to vendor the crates.
I'm not sure how to update that version
The text was updated successfully, but these errors were encountered: