AML: Correctly invoke _SEG,_BBN, and _ADR methods for PCI region accesses, plus assorted bits
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because these methods will need to invoke methods in the future. Co-authored-by: Ron Williams <ron.williams.redox@gmail.com>
Co-authored-by: Ron Williams <ron.williams.redox@gmail.com>
Easy change while we're here
Lots of the field reading/writing behaviour isn't quite correct yet, but this was getting unwieldly and spread about multiple places. Creating this abstraction will hopefully help in future.
For some reason, this *definitely* required an extra scope before, but doesn't seem to now...
|
cc @rw-vanc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #155
This changes various methods around the interpreter to take a mutable reference to the
AmlContext, which creates some borrow checking problems, but also allows us to invoke control methods from field accesses. This is required for fields located in PCI config space, as they need to invoke the_SEG,_BBN, and_ADRmethods to correctly access the PCI bridge.Also contains changes that were sensible to make while addressing the fallout of these changes.