Exit codes indicate success or failure #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Looks good to me. bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 13, 2019
33: Exit codes indicate success or failure r=phil-opp a=foeb Discussed here: #32 > To implement this, we would need to check for the exit code in QEMU: > * If it's `0`, do everything the same way as before for backwards compatibility. > * An exit code of `2` indicates success -> mark the test as succeeded without looking at the serial output > * An exit code of `3` indicates failure -> mark the test as failed and print every serial output after a special string such as `failed\n` or `test failed:`. Thanks for considering this feature! Co-authored-by: Phoebe Bell <minaphoebebell@gmail.com>
Build succeeded |
|
Published as version 0.6.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here: #32
Thanks for considering this feature!