Fix linker errors on latest nightlies #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the
leainstructions get addresses of non-addressable memory locations. Instead, usemov <reg>, offset <label>instructions, which are the equivalent tomov <reg>, labelinstructions innasm.I'm not sure why the
leaworked before, but maybe LLVM used to optimize theleas tomovinstructions. Either way, the LLVM version used by the latest Rust nightly doesn't like theleainstructions anymore.This PR includes a lot of commits where I tried to fix the Windows CI, which currently fails because of a bug in QEMU. Unfortunately, I wasn't able to get it working, so I just hope for a new QEMU release now. For the meantime, I disabled the
fail-fastproperty so that we at least don't cancel the macOS build when the Windows job fails. (I kept the debug commits in this PR in case so that I don't need to rember which approaches I tried the next time I debug this.)Fixes rust-osdev/bootimage#73 and fixes phil-opp/blog_os#937