Logger: nicer font rendering into framebuffer #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
replace-font8x8-with-noto-sans-mono
branch
from
6ba97ed
to
ed35368
Compare
|
Looks way better, thanks a lot for the PR and for writing this crate! We should mention the crate in the Rust OSDev newsletter, it's probably useful to many other people too. Do you have some time to write add a few sentences about it to rust-osdev/homepage#84, or should I try to do it? |
|
Thanks @phil-opp! Regarding the newsletter: Sure, great idea! I can do it. |
|
These changes introduce an attribute change that generates needless compiler warnings on Rust 1.60+. I've submitted a pull request of my own to address this. |
|
They don't. The warnings are listed under "Unchanged files with check annotations" indicating that this PR didn't change it. It is the result of rustc nightly stabilizing the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ugly 8x8 bitmap font and replaces it by a much nicer alternative: noto-sans-mono-bitmap. It is similar size efficient (doesn't bloat the binary), no_std compatible, uses zero allocations, and no floating point operations.
Before:
After: