Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log level feature #303

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Log level feature #303

merged 7 commits into from
Jan 3, 2023

Conversation

asensio-project
Copy link
Contributor

@asensio-project asensio-project commented Dec 30, 2022 •
edited
Loading

Hello,

This PR adds a log_level configuration in bootloader_api. Now, the developers of the kernel can change which kind of messages are shown in the screen when booting.

Thanks for this project.

(This is the replacement of #292)

Resolves #288

This was referenced Dec 30, 2022
Closed
Closed
phil-opp
phil-opp reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me overall, but I would prefer to create our own copy of the LevelFilter enum instead of adding a log dependency to the bootloader_api crate (see my comments below).

api/src/config.rs Outdated Show resolved Hide resolved
api/Cargo.toml Outdated Show resolved Hide resolved
api/src/config.rs Outdated Show resolved Hide resolved
@asensio-project
Copy link
Contributor Author

Since d1da62f, this PR doesn't depend in the log crate for the API.

phil-opp
phil-opp approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick update!

@phil-opp phil-opp enabled auto-merge (squash) January 3, 2023 07:21
@phil-opp phil-opp merged commit fffa7ce into rust-osdev:main Jan 3, 2023
@phil-opp phil-opp mentioned this pull request Jan 3, 2023
Closed
@phil-opp phil-opp mentioned this pull request Mar 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a QUIET feature
2 participants
@asensio-project @phil-opp