Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volatile accesses in VGA code and make font dependency optional #67

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@64
Copy link
Contributor

commented Jul 15, 2019

  1. Make VGA code use volatile accesses (in reality, won't make much of a difference, but is good practice and sets a good example for people who are reading the code).

  2. Make the font dependency optional and only pull it in if the vga_320x200 feature is enabled.

@phil-opp
Copy link
Member

left a comment

Looks good to me, thanks!

@phil-opp phil-opp merged commit 0e7f27d into rust-osdev:master Jul 16, 2019

4 checks passed

rust-osdev.bootloader Build #20190715.4 succeeded
Details
rust-osdev.bootloader (Job linux) Job linux succeeded
Details
rust-osdev.bootloader (Job mac) Job mac succeeded
Details
rust-osdev.bootloader (Job windows) Job windows succeeded
Details

phil-opp added a commit that referenced this pull request Jul 16, 2019

@phil-opp

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Published as version 0.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.