Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volatile accesses in VGA code and make font dependency optional #67

merged 2 commits into from Jul 16, 2019


Copy link

commented Jul 15, 2019

  1. Make VGA code use volatile accesses (in reality, won't make much of a difference, but is good practice and sets a good example for people who are reading the code).

  2. Make the font dependency optional and only pull it in if the vga_320x200 feature is enabled.

Copy link

left a comment

Looks good to me, thanks!

@phil-opp phil-opp merged commit 0e7f27d into rust-osdev:master Jul 16, 2019

4 checks passed

rust-osdev.bootloader Build #20190715.4 succeeded
rust-osdev.bootloader (Job linux) Job linux succeeded
rust-osdev.bootloader (Job mac) Job mac succeeded
rust-osdev.bootloader (Job windows) Job windows succeeded

phil-opp added a commit that referenced this pull request Jul 16, 2019


This comment has been minimized.

Copy link

commented Jul 16, 2019

Published as version 0.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.