Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way the kernel entry point is called to honor alignement ABI #81

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@GuillaumeDIDIER
Copy link
Contributor

GuillaumeDIDIER commented Oct 7, 2019

Compilers expect functions to be called with the stack containing the return address making the rsp be 8 mod 16. jmp caused rsp to be 0 mod 16 (aka 16 bytes aligned), which then caused compiler to meke the stack misaligned everywhere.

Fix #80

Compilers expect functions to be called with the stack containing the return address making the rsp be 8 mod 16. jmp caused rsp to be 0 mod 16 (aka 16 bytes aligned), which then caused compiler to meke the stack misaligned everywhere.
@GuillaumeDIDIER

This comment has been minimized.

Copy link
Contributor Author

GuillaumeDIDIER commented Oct 7, 2019

Apparently the test just blew up because rustfmt is unavailable in todays nightly 😱

@GuillaumeDIDIER

This comment has been minimized.

Copy link
Contributor Author

GuillaumeDIDIER commented Oct 8, 2019

Note all the test passed apart from the missing rustfmt.

@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented Oct 8, 2019

@GuillaumeDIDIER Thanks for reporting and directly fixing this issue!

Don't worry about the failing rustfmt checks. This is a known problem and I already have a solution in mind. I'm planning to rewrite the CI scripts and update the testing framework soon, and I will fix it then.

@phil-opp phil-opp merged commit 4e3b456 into rust-osdev:master Oct 8, 2019
0 of 4 checks passed
0 of 4 checks passed
rust-osdev.bootloader Build #20191007.1 failed
Details
rust-osdev.bootloader (Job linux) Job linux failed
Details
rust-osdev.bootloader (Job mac) Job mac failed
Details
rust-osdev.bootloader (Job windows) Job windows failed
Details
phil-opp added a commit that referenced this pull request Oct 9, 2019
@phil-opp

This comment has been minimized.

Copy link
Member

phil-opp commented Oct 9, 2019

Published as version 0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.