multiboot2: create DSTs: hopefully better memory fix #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
fixes2
branch
2 times, most recently
from
70a5c95
to
eb71d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There where more memory issues (according to miri) in the boxed_dst_tag function. I tried many things but I came to the conclusion:
Making every struct packed would help to satisfy miri with allocations/deallocations but using packed structs in Rust is a pain for itself. Using packed DSTs is a total meltdown...
So I think, using my own Boxed-like wrapper is the best solution we can have so far. I'm 99% certain that there are no memory issues at runtime and that only miri complains under certain cirumstances.