Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the repo to build edk2 release tags #1

Merged
merged 1 commit into from May 21, 2023

Conversation

nicholasbishop
Copy link
Contributor

The builder this repo used to pull from has been turned off. It would be nice to have up-to-date edk2 release builds for use with testing in https://github.com/rust-osdev/uefi-rs, without relying on the vagaries of Linux distro releases. Doing our own builds also allows us to ensure we have exactly the build options we want for use with VM testing.

As described in the readme, the intended usage is manually pushing a tag corresponding to a release tag in the edk2 repo. That tag will be built in a container, and the resulting tarball will be pushed as a release in this repo (as long as the release doesn't already exist.)

I've intentionally kept the container build very simple and linear to make it clear what options are being set for each edk2 build. That leads to some duplication there, but I think the end result is quite easy to follow.

Here's an example release from my testing in a fork: https://github.com/nicholasbishop/ovmf-prebuilt/releases/tag/edk2-stable202211-r3

The builder this repo used to pull from has been turned off. It would be
nice to have up-to-date edk2 release builds for use with testing in
https://github.com/rust-osdev/uefi-rs, without relying on the vagaries
of Linux distro releases. Doing our own builds also allows us to ensure
we have exactly the build options we want for use with VM testing.

As described in the readme, the intended usage is manually pushing a tag
corresponding to a release tag in the edk2 repo. That tag will be built
in a container, and the resulting tarball will be pushed as a release in
this repo (as long as the release doesn't already exist.)

I've intentionally kept the container build very simple and linear to
make it clear what options are being set for each edk2 build. That leads
to some duplication there, but I think the end result is quite easy to
follow.
@nicholasbishop
Copy link
Contributor Author

@phil-opp any thoughts on this change? If you're OK with it I'll merge this and handle pushing tags to trigger release builds.

@phil-opp
Copy link
Member

Thanks a lot for looking into this! I'm currently on vacation, but I'll take a closer look once I'm back. The approach looks good to me in general, so feel free to merge this already without my review.

@nicholasbishop
Copy link
Contributor Author

Sounds good, thanks!

@nicholasbishop nicholasbishop merged commit 465cfb8 into rust-osdev:main May 21, 2023
1 check passed
@nicholasbishop nicholasbishop deleted the bishop-rust-docker branch May 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants