Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to a workspace #39

Merged
merged 2 commits into from Mar 6, 2024
Merged

Transition to a workspace #39

merged 2 commits into from Mar 6, 2024

Conversation

nicholasbishop
Copy link
Contributor

Move the build code to a new build-edk2 package.

This is a precursor to adding a second package to the workspace: #38

@nicholasbishop
Transition to a workspace
e68262b 
Move the build code to a new build-edk2 package.

This is a precursor to adding a second package to the workspace:
#38
phil-opp
phil-opp approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We probably need to update our CI scripts too, e.g. with additional --workspace or --package arguments.

@nicholasbishop
Copy link
Contributor Author

Good call, updated the cargo commands.

@nicholasbishop nicholasbishop merged commit 717efb8 into main Mar 6, 2024
1 check passed
@nicholasbishop nicholasbishop deleted the bishop-workspace branch March 6, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicholasbishop @phil-opp