Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is broken: "GlobalValue with DLLImport Storage is dso_local!" #500

Closed
nicholasbishop opened this issue Sep 2, 2022 · 5 comments · Fixed by #516
Closed

CI is broken: "GlobalValue with DLLImport Storage is dso_local!" #500

nicholasbishop opened this issue Sep 2, 2022 · 5 comments · Fixed by #516

Comments

@nicholasbishop
Copy link
Contributor

Here we go again I guess :) Hot on the heels of #494, it looks like compilation is broken on latest nightly again: https://github.com/rust-osdev/uefi-rs/actions/runs/2980534507

...
GlobalValue with DLLImport Storage is dso_local!
ptr @_ZN3log20MAX_LOG_LEVEL_FILTER17h16709ec7a7aa195bE
LLVM ERROR: Broken module found, compilation aborted!
error: could not compile `uefi-services`

From a very quick search I don't see an existing issue in the rust repo for this, I'll try to bisect it later and file an issue.
@nicholasbishop nicholasbishop pinned this issue Sep 2, 2022
@asensio-project
Copy link

How can I bisect it properly? I read the quick guide but it's not working for me.

@asensio-project
Copy link

I opened an issue for fixing this.

@nicholasbishop
Copy link
Contributor Author

Thanks for filing that bug, confirmed that the PR you identified seems to be causing the breakage. I left a comment with details of what I ran to bisect.

@asensio-project
Copy link

Thanks! Do you know a possible solution or something similar?

nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 4, 2022
@nicholasbishop
Pin to a working nightly
39869a4 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 4, 2022
@nicholasbishop
Pin to a working nightly
ff9b514 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 4, 2022
@nicholasbishop
Pin to a working nightly
df039a5 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 4, 2022
@nicholasbishop
Pin to a working nightly
154d4bf 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 5, 2022
@nicholasbishop
Pin to a working nightly
e54e1fb 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 5, 2022
@nicholasbishop
Pin to a working nightly
c083e9a 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 5, 2022
@nicholasbishop
Pin to a working nightly
d30b454 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 6, 2022
@nicholasbishop
Pin to a working nightly
7a936fd 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
rust-osdev#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once rust-osdev#500 is fixed.
nicholasbishop added a commit that referenced this issue Sep 6, 2022
@nicholasbishop
Pin to a working nightly
c6088c0 
Temporarily modify rust-toolchain.toml to pin to `nightly-2022-08-26`,
as compilation is broken on current nightly due to
#500. `nightly-2022-09-01`
is the most recent nightly that avoids the bug, but it doesn't have miri
(which is run by CI), so pin to a slightly older version.

Also pinned the toolchain in the template app.

This change should be reverted once #500 is fixed.
@asensio-project
Copy link

asensio-project commented Sep 10, 2022 •
edited

The pr it's merged and the issue closed. I'm waiting for this version of the nightly of rustc.

nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 24, 2022
@nicholasbishop
Switch the toolchain back to latest nightly
6ee4edb 
The bug in nightly Rust that was causing problems for us has been fixed,
so switch back to latest nightly.

Fixes rust-osdev#500
@nicholasbishop nicholasbishop mentioned this issue Sep 24, 2022
Merged
2 tasks
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 24, 2022
@nicholasbishop
Switch the toolchain back to latest nightly
5ba985c 
The bug in nightly Rust that was causing problems for us has been fixed,
so switch back to latest nightly.

Fixes rust-osdev#500
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 25, 2022
@nicholasbishop
Switch the toolchain back to latest nightly
a2ee10d 
The bug in nightly Rust that was causing problems for us has been fixed,
so switch back to latest nightly.

Fixes rust-osdev#500
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this issue Sep 25, 2022
@nicholasbishop
Switch the toolchain back to latest nightly
5b64b9e 
The bug in nightly Rust that was causing problems for us has been fixed,
so switch back to latest nightly.

Fixes rust-osdev#500
nicholasbishop added a commit that referenced this issue Sep 25, 2022
@nicholasbishop
Switch the toolchain back to latest nightly
1f4140d 
The bug in nightly Rust that was causing problems for us has been fixed,
so switch back to latest nightly.

Fixes #500
@nicholasbishop nicholasbishop unpinned this issue Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch the toolchain back to latest nightly nicholasbishop/uefi-rs
2 participants
@nicholasbishop @asensio-project