Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release uefi-0.25.0 #954

Closed
phip1611 opened this issue Oct 6, 2023 · 7 comments
Closed

Release uefi-0.25.0 #954

phip1611 opened this issue Oct 6, 2023 · 7 comments
Assignees

Comments

@phip1611
Copy link
Contributor

phip1611 commented Oct 6, 2023

It's quite some time since the last release. We releases 0.24 in June and we should Release 0.25 next. (I know someone that asked politely for a new release.)

PS: @nicholasbishop If you don't mind, maybe I can do the release this time? You always did this so far. Might be good if I'm also familiar with the process so that we don't have a single-point-of-failure :) Is there anything I need to know for that beside what's in PUBLISHING.md?

@phip1611 phip1611 self-assigned this Oct 6, 2023
@phip1611 phip1611 changed the title Release uefi-0.24.0 Release uefi-0.25.0 Oct 6, 2023
@phip1611
Copy link
Contributor Author

phip1611 commented Oct 6, 2023

Is there a reason why there aren't any entries for uefi-raw in the changelog?

@nicholasbishop
Copy link
Contributor

Is there a reason why there aren't any entries for uefi-raw in the changelog?

Not a strong one, I just figured that since the library was still in the early stages and churning a lot, changelogs wouldn't be very useful. But we could start adding them going forward.

If you don't mind, maybe I can do the release this time? You always did this so far. Might be good if I'm also familiar with the process so that we don't have a single-point-of-failure :) Is there anything I need to know for that beside what's in PUBLISHING.md?

Sounds good! I think PUBLISHING.md is accurate, but I've been following some local notes I made that use cargo-release. There's one surprising thing, which is that cargo release isn't updating version numbers automatically, and I don't know why. It works in other projects, so must be something weird in our repo. I've been meaning to integrate these notes into publishing.md, but haven't gotten around to it yet. Here's what I have in my notes:

  1. File a release bug. See Release uefi-macros-0.10.0, uefi-0.19.0, and uefi-services-0.16.0 #637 for example. Doesn't need to contain much, just the versions you intend to release.
  2. Make sure everything you intend to have merged in is merged.
  3. Install or update the cargo-release tool: cargo install cargo-release
  4. Make sure your local repo is up to date: git checkout main && git pull
  5. Checkout a new branch to contain the release commits: git checkout -b <some-branch-name>
  6. Push the branch to the main repo (not a fork): git push -u origin <some-branch-name>
  7. Run cargo release in dry-run mode. For example: cargo release -p uefi-raw 0.1.0
  8. Run it for real: cargo release -p uefi-raw 0.1.0 --execute
  9. Update uefi-raw version in uefi/Cargo.toml. Make sure to cargo xtask build after to update the lock file. Commit the change. TODO: why isn't cargo release handling this?
  10. Order of releases: uefi-raw, uefi-macros, uefi, uefi-services
  11. Update deps in template/Cargo.toml and book/src/tutorial/app.md
  12. Update changelog.
  13. Merge branch into main via PR.
  14. Close ticket.

@phip1611
Copy link
Contributor Author

phip1611 commented Oct 9, 2023

Interesting, I've never heard of cargo-release , I always did the relevant steps manually in my own projects.

@phip1611
Copy link
Contributor Author

phip1611 commented Oct 9, 2023

Closing in favor of #955

@phip1611 phip1611 closed this as completed Oct 9, 2023
@phip1611
Copy link
Contributor Author

phip1611 commented Oct 9, 2023

Hm, on a first glance, understanding how cargo release works takes 2x more time than doing things manually. I hope I don't mess something up

@phip1611
Copy link
Contributor Author

phip1611 commented Oct 9, 2023

@nicholasbishop you are the owner of uefi-raw, I can't publish. Can you please add @GabrielMajeri and me?

@nicholasbishop
Copy link
Contributor

Ah sorry about that! I have sent you both invites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants