Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release uefi-raw-0.4.0, uefi-0.25.0, and uefi-services-0.22.0 #955

Closed
phip1611 opened this issue Oct 9, 2023 · 4 comments · Fixed by #958 or #960
Closed

Release uefi-raw-0.4.0, uefi-0.25.0, and uefi-services-0.22.0 #955

phip1611 opened this issue Oct 9, 2023 · 4 comments · Fixed by #958 or #960
Assignees

Comments

@phip1611
Copy link
Contributor

phip1611 commented Oct 9, 2023

  • uefi: 0.24 -> 0.25
  • uefi-raw: 0.3 -> 0.4

uefi-macros and uefi-services are unchanged since the last release, i.e., nothign to do here.

@phip1611 phip1611 self-assigned this Oct 9, 2023
This was referenced Oct 9, 2023
@nicholasbishop
Copy link
Contributor

I think we also need to release uefi-services with an updated dep on uefi. In cargo's version of semver, it treats the left-most non-zero value as a major version. Since uefi-services depends on uefi-0.24.0, that means uefi-0.25.0 is considered incompatible. That leads to errors like:

error[E0308]: mismatched types
  --> src/main.rs:9:25
   |
9  |     uefi_services::init(&mut system_table).unwrap();
   |     ------------------- ^^^^^^^^^^^^^^^^^ expected `uefi::table::system::SystemTable<uefi::table::system::Boot>`, found `uefi::table::SystemTable<uefi::table::Boot>`
   |     |
   |     arguments to this function are incorrect
   |
   = note: `uefi::table::SystemTable<uefi::table::Boot>` and `uefi::table::system::SystemTable<uefi::table::system::Boot>` have similar names, but are actually distinct types

@phip1611
Copy link
Contributor Author

phip1611 commented Oct 11, 2023

Ohhh... I'm sorry about that. I wonder why CI didn't catch this?

I'm at the EuroRust, so I don't know if I have time for this soon.

@nicholasbishop
Copy link
Contributor

No worries, I'll take care of it later today. Good question about CI, I'll take a look at that too.

@nicholasbishop nicholasbishop changed the title Release uefi-raw-0.4.0 and uefi-0.25.0 Release uefi-raw-0.4.0, uefi-0.25.0, and uefi-services-0.22.0 Oct 11, 2023
@nicholasbishop
Copy link
Contributor

Re the CI not catching it: #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants