Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi: Add TryFrom u8 slice to DevicePathHeader #1199

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

andre-braga
Copy link
Contributor

Allows for making a DevicePathHeader from a byte splice, used primarily to verify whether the byte splice can also contain DevicePathHeader.length bytes.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@andre-braga andre-braga marked this pull request as draft June 11, 2024 16:13
@andre-braga andre-braga changed the title uefi: implement DevicePathHeader::from_ffi_ptr uefi: Add TryFrom u8 slice to DevicePathHeader Jun 11, 2024
@andre-braga andre-braga force-pushed the header branch 3 times, most recently from 4c702ab to 90e201a Compare June 11, 2024 16:20
@andre-braga andre-braga marked this pull request as ready for review June 11, 2024 16:21
Copy link
Contributor

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Allows for making a `DevicePathHeader` from a byte splice,
used primarily to verify whether the byte splice can also
contain `DevicePathHeader.length` bytes.
@phip1611
Copy link
Contributor

Thanks for your contribution!

@phip1611 phip1611 enabled auto-merge June 11, 2024 16:35
@phip1611 phip1611 added this pull request to the merge queue Jun 11, 2024
Merged via the queue into rust-osdev:main with commit b04209e Jun 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants