New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose device path types #202
Expose device path types #202
Conversation
This fix allows to expose the `DeviceType` and `DeviceSubType` enumerations.
Yep, makes sense. Initially it was only used internally in the |
@GabrielMajeri I think it's ready for you to take a look 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, just a few small nitpicks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
This fix allows to expose the
DeviceType
andDeviceSubType
enumerations.I'm also thinking about moving the device_path modules outside loader_image since, on the UEFI specification, those are two separated protocols. What are your thoughts on this?
Edit
Here we can see a usage example of the
AcpiDevicePath
in use.