Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose device path types #202

Merged
merged 6 commits into from Mar 6, 2021

Conversation

gil0mendes
Copy link
Contributor

@gil0mendes gil0mendes commented Feb 28, 2021

This fix allows to expose the DeviceType and DeviceSubType enumerations.

I'm also thinking about moving the device_path modules outside loader_image since, on the UEFI specification, those are two separated protocols. What are your thoughts on this?

Edit
Here we can see a usage example of the AcpiDevicePath in use.

This fix allows to expose the `DeviceType` and `DeviceSubType` enumerations.
@GabrielMajeri
Copy link
Collaborator

I'm also thinking about moving the device_path modules outside loader_image since, on the UEFI specification, those are two separated protocols.

Yep, makes sense. Initially it was only used internally in the loaded_image protocol, but it might be useful in other cases as well.

@gil0mendes
Copy link
Contributor Author

@GabrielMajeri I think it's ready for you to take a look 🤗

Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, just a few small nitpicks!

src/table/boot.rs Show resolved Hide resolved
src/proto/device_path.rs Outdated Show resolved Hide resolved
src/proto/device_path.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@GabrielMajeri GabrielMajeri merged commit 20f0ca8 into rust-osdev:master Mar 6, 2021
@gil0mendes gil0mendes deleted the fix/expose-device-type branch March 6, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants