Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make using the stdio handles require a mutable ref #240

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Make using the stdio handles require a mutable ref #240

merged 2 commits into from
Jun 12, 2021

Conversation

GabrielMajeri
Copy link
Collaborator

Updates the system table's stdin/stdout/stderr methods require a &mut reference.

Fixes #239

@GabrielMajeri GabrielMajeri mentioned this pull request Jun 12, 2021
Closed
toku-sa-n
toku-sa-n reviewed Jun 12, 2021
View reviewed changes
Copy link
Member

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I think this solves the problem. I added comments for the styling issue.

src/table/system.rs Outdated Show resolved Hide resolved
src/table/system.rs Outdated Show resolved Hide resolved
@GabrielMajeri GabrielMajeri merged commit 80ea650 into master Jun 12, 2021
@GabrielMajeri GabrielMajeri deleted the borrow-stdio-handles-mut branch June 12, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toku-sa-n toku-sa-n toku-sa-n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std(in|out|err) methods can create multiple mutable references to the same object
2 participants
@GabrielMajeri @toku-sa-n