Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtask: Add OVMF_CODE/OVMF_VARS env vars #700

Merged
merged 1 commit into from Mar 24, 2023

Conversation

nicholasbishop
Copy link
Contributor

The search order for finding the OVMF files is now:

  1. Command-line argument (--ovmf-code, --ovmf-vars)
  2. Environment variable (OVMF_CODE, OVMF_VARS)
  3. OS-dependent paths

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Copy link
Contributor Author

@phip1611 I wanted to suggest changing slightly how the env vars in #690 get checked so that it happens after checking the CLI args, but figuring out how to type it up in a comment was harder than just putting up a PR, so here it is :)

@phip1611
Copy link
Contributor

Nice, LGTM

The search order for finding the OVMF files is now:
1. Command-line argument (`--ovmf-code`, `--ovmf-vars`)
2. Environment variable (`OVMF_CODE`, `OVMF_VARS`)
3. OS-dependent paths
@phip1611 phip1611 merged commit 77a7a32 into rust-osdev:main Mar 24, 2023
11 checks passed
@nicholasbishop nicholasbishop deleted the bishop-check-env branch March 24, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants