uefi: Remove some uses of MaybeUninit in BootServices #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
approved these changes
Jun 10, 2023
While `MaybeUninit` is useful to avoid unnecessarily initializing large buffers, it's not needed for small values like single pointers and integers. For `Event`, `Handle`, and `ProtocolSearchKey`, which internally contain a `NonNull` pointer, we can wrap them in an `Option` and still have the same layout as a raw pointer. The initial value can then be `None` rather than `MaybeUninit`. This has the nice side effect of removing a little bit of `unsafe` code.
nicholasbishop
force-pushed
the
bishop-less-maybeuninit
branch
from
b94dc20
to
58ed2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
MaybeUninitis useful to avoid unnecessarily initializing large buffers, it's not needed for small values like single pointers and integers.For
Event,Handle, andProtocolSearchKey, which internally contain aNonNullpointer, we can wrap them in anOptionand still have the same layout as a raw pointer. The initial value can then beNonerather thanMaybeUninit.This has the nice side effect of removing a little bit of
unsafecode.Checklist