uefi: Improve support for null protocol interfaces #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-dp-null-2
branch
2 times, most recently
from
bef210b
to
d8145f4
Compare
phip1611
reviewed
Jun 19, 2023
phip1611
approved these changes
Jun 19, 2023
Modify `ScopedProtocol` to check if the interface pointer is null. If it is, then `Deref` and `DerefMut` will now panic. They are also now marked `#[track_caller]` so that the panic location points to the caller. Also added `get` and `get_mut` methods to get potentially-null interface data without panicking.
nicholasbishop
force-pushed
the
bishop-fix-dp-null-2
branch
from
d8145f4
to
7b5271c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
ScopedProtocolto check if the interface pointer is null. If it is, thenDerefandDerefMutwill now panic. They are also now marked#[track_caller]so that the panic location points to the caller.Also added
getandget_mutmethods to get potentially-null interface data without panicking.This is a minimal fix for the issue described in #859. I'm not sure if it's the best long-term fix, but I'm wary of doing anything too invasive until we have better Miri coverage of protocols.
Checklist