Drop memmove and set_mem from boot services
#906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no good reason to the UEFI version of these functions over core Rust functions like `core::ptr::copy` and `core::ptr::write_bytes`. The safety requirements of the `core` functions are also better documented.
phip1611
approved these changes
Aug 1, 2023
|
That merge train feature is really nice 👍🏻 I like it @nicholasbishop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason to the UEFI version of these functions over core Rust functions like
core::ptr::copyandcore::ptr::write_bytes. The safety requirements of thecorefunctions are also better documented.Checklist