New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uefi: Change IMAGE_HANDLE to an atomic pointer #976

Merged

phip1611 merged 1 commit into rust-osdev:main from nicholasbishop:bishop-atomic-image-handle

Oct 27, 2023

Contributor

nicholasbishop commented Oct 27, 2023

This aligns with how the std uefi target works:
https://github.com/rust-lang/rust/blob/f654229c27267334023a22233795b88b75fc340e/library/std/src/os/uefi/env.rs#L9

And also avoids some unsafe; a static atomic be written without being static mut, and reads and writes are safe operations.

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
Update the changelog (if necessary)


          uefi: Change IMAGE_HANDLE to an atomic pointer

c431ae4

This aligns with how the std uefi target works:
https://github.com/rust-lang/rust/blob/f654229c27267334023a22233795b88b75fc340e/library/std/src/os/uefi/env.rs#L9

And also avoids some unsafe; a static atomic be written without being `static
mut`, and reads and writes are safe operations.

phip1611 approved these changes

View reviewed changes

phip1611 added this pull request to the merge queue

Merged via the queue into rust-osdev:main with commit 166716f

12 checks passed

nicholasbishop deleted the bishop-atomic-image-handle branch

October 27, 2023 15:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment