Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest versions to fix E0557 #23

Merged
merged 1 commit into from May 19, 2021

Conversation

ethindp
Copy link
Contributor

@ethindp ethindp commented May 16, 2021

This fixes E0557 caused in Rust v. 1.53 plus.

Signed-off-by: Ethin Probst ethindp@protonmail.com

Signed-off-by: Ethin Probst <ethindp@protonmail.com>
@littledivy
Copy link

friendly ping @RKennedy9064 :)

@RKennedy9064 RKennedy9064 merged commit 224281d into rust-osdev:master May 19, 2021
@RKennedy9064
Copy link
Member

@ethindp @littledivy Thanks for the fix/updates. I haven't really had any time to work on side projects lately.

@ethindp
Copy link
Contributor Author

ethindp commented May 19, 2021 via email

@RKennedy9064
Copy link
Member

I think it might be a cache issue or something? Just saw a similar error with regards to the same issue on an AWS issue. I'll try to look into it when I have some more time. This if the issue I found if you're curious compound-finance/gateway#328

@phil-opp
Copy link
Member

I think the problem is the pic8259_simple dependency in testing/Cargo.toml:

pic8259_simple = "0.2.0"

The crate is currently broken and it seems like it is not maintained anymore. For this reason I forked it under the rust-osdev organization: emk/toyos-rs#9 (comment). Switching to that crate should fix the CI errors.

@RKennedy9064
Copy link
Member

@phil-opp Thanks for the update. Didn't realize you forked it. Just updated the dependency and it looks like the tests are running correctly now.

@Freax13
Copy link

Freax13 commented Jun 2, 2021

would you mind pushing this to crates.io?

@RKennedy9064
Copy link
Member

@Freax13 Sorry about that, forgot to publish when I updated. It should be up to date on crates.io now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants