Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementations for
fmt::Pointer
,PartialEq
,Eq
,PartialOrd
,Ord
andHash
in analogy toNonNull
.In the second commit, I shorten the output of
fmt::Debug
(which is now also analogous toNonNull
) because printing outVolatilePtr
as an entire struct every time{:#?}
formatting is used makes debug output harder to read. I can revert that commit if you disagree.I also removed the
T: Copy + fmt::Debug
bounds on thefmt::Debug
implementations because they made no sense to me.