Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: added help on update_flags to get flags #465

Merged
merged 3 commits into from Mar 9, 2024
Merged

doc: added help on update_flags to get flags #465

merged 3 commits into from Mar 9, 2024

Conversation

Sxmourai
Copy link
Contributor

@Sxmourai Sxmourai commented Mar 7, 2024

Added as asked by phil opp, see #461

phil-opp
phil-opp reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you move the sentence before the ## Safety heading? And maybe reword it as:

To read the current flags of a mapped page, use the [`Translate::translate`] method.

The brackets around the Translate::translate should make rustdoc create a link.

@Freax13
Copy link
Contributor

Freax13 commented Mar 9, 2024

CI's not yet quite happy.

Freax13
Freax13 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Freax13 Freax13 merged commit 43eb701 into rust-osdev:master Mar 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp left review comments

@Freax13 Freax13 Freax13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sxmourai @Freax13 @phil-opp