Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add aliases for in{,b,w,l} and out{,b,w,l} #474

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mkroening
Copy link
Member

With this PR you can find PortRead::read_from_port and PortWrite::write_to_port via in{,b,w,l} and out{,b,w,l} respectively.

Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Shouldn't we rather add the aliases to Port::read and Port::write though since those are the methods users are most likely to use? There seem to be some people implementing PortRead/PortWrite themselves for their own types, but I would guess that there are more uses of Port::read/Port::write.

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@mkroening
Copy link
Member Author

Shouldn't we rather add the aliases to Port::read and Port::write though since those are the methods users are most likely to use?

Good point! I changed it. 👍

@mkroening mkroening requested a review from Freax13 April 4, 2024 15:19
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit b9a642a into rust-osdev:master Apr 4, 2024
12 checks passed
@mkroening mkroening deleted the port-alias branch April 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants