Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new OffsetPageTable mapper type #83

Merged
merged 7 commits into from
Jul 17, 2019
Merged

Add a new OffsetPageTable mapper type #83

merged 7 commits into from
Jul 17, 2019

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Jul 8, 2019

The type wraps a MappedPageTable instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a static.

TODO:

  • Make phys_offset a VirtAddr instead of an u64

Fixes #81

@phil-opp
Copy link
Member Author

phil-opp commented Jul 9, 2019

Pre-published as version 0.7.2-beta.0 for experimentation.

A trait implementation for `Fn(PhysFrame) -> *mut PageTable` is provided, so this change shouldn't break any existing code.
The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.
@phil-opp
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp

The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.

TODO:

- [x] Make `phys_offset` a `VirtAddr` instead of an `u64` 

Fixes #81 

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors
Copy link
Contributor

bors bot commented Jul 17, 2019

Canceled

@phil-opp
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp

The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.

TODO:

- [x] Make `phys_offset` a `VirtAddr` instead of an `u64` 

Fixes #81 

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors
Copy link
Contributor

bors bot commented Jul 17, 2019

Build succeeded

  • rust-osdev.x86_64

@bors bors bot merged commit cdde870 into master Jul 17, 2019
@bors bors bot deleted the offset_page_table branch July 17, 2019 09:34
@phil-opp
Copy link
Member Author

Published as version 0.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify MappedPageTable type?
1 participant