Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new `OffsetPageTable` mapper type #83

Merged
merged 7 commits into from Jul 17, 2019

Conversation

@phil-opp
Copy link
Member

commented Jul 8, 2019

The type wraps a MappedPageTable instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a static.

TODO:

  • Make phys_offset a VirtAddr instead of an u64

Fixes #81

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Pre-published as version 0.7.2-beta.0 for experimentation.

@phil-opp phil-opp force-pushed the offset_page_table branch from 29ea359 to a358d4c Jul 17, 2019

phil-opp added some commits Jul 8, 2019

Use a PhysToVirt trait instead of `Fn(PhysFrame) -> *mut PageTable`
A trait implementation for `Fn(PhysFrame) -> *mut PageTable` is provided, so this change shouldn't break any existing code.
Add a new `OffsetPageTable` mapper type
The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.

@phil-opp phil-opp force-pushed the offset_page_table branch from a358d4c to aef984b Jul 17, 2019

phil-opp added some commits Jul 17, 2019

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 17, 2019

Merge #83
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp

The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.

TODO:

- [x] Make `phys_offset` a `VirtAddr` instead of an `u64` 

Fixes #81 

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Canceled

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 17, 2019

Merge #83
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp

The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.

TODO:

- [x] Make `phys_offset` a `VirtAddr` instead of an `u64` 

Fixes #81 

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Build succeeded

  • rust-osdev.x86_64

@bors bors bot merged commit cdde870 into master Jul 17, 2019

7 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
rust-osdev.x86_64 Build #20190717.7 succeeded
Details
rust-osdev.x86_64 (Job linux) Job linux succeeded
Details
rust-osdev.x86_64 (Job mac) Job mac succeeded
Details
rust-osdev.x86_64 (Job windows) Job windows succeeded
Details

@bors bors bot deleted the offset_page_table branch Jul 17, 2019

@phil-opp

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Published as version 0.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.