Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ux dependency with custom wrapper structs #91

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Replace ux dependency with custom wrapper structs #91

merged 3 commits into from
Dec 10, 2019

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Sep 25, 2019 •
edited
Loading

This pull request introduces a new PageTableIndex type instead of ux::u9. Likewise, it introduces a new PageOffset instead of ux::u12. To migrate, you need to switch to the new types.

cc #90

This is a breaking change.

@phil-opp phil-opp mentioned this pull request Sep 25, 2019
Closed
@phil-opp
Copy link
Member Author

phil-opp commented Dec 5, 2019

There were no objections in the last months, so I think we can merge this.

bors r+

bors bot added a commit that referenced this pull request Dec 5, 2019
@bors @phil-opp
Merge #91
26bb028 
91: Replace `ux` dependency with custom wrapper structs r=phil-opp a=phil-opp

cc #90 


Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@bors
Copy link
Contributor

bors bot commented Dec 5, 2019

Timed out

@phil-opp phil-opp merged commit 63eb6ad into master Dec 10, 2019
@phil-opp phil-opp deleted the remove-ux branch December 10, 2019 13:33
phil-opp added a commit that referenced this pull request Dec 13, 2019
@phil-opp
Update changelog for #91
2cfbc7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@phil-opp