Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update criterion #181

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Update criterion #181

merged 2 commits into from
Oct 15, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Oct 15, 2019

Noticed it was outdated.

Also passes tests when line 14 is removed but I left it because I have no idea why gen_hash_test.rs is a binary.

@abonander
Copy link
Collaborator

abonander commented Oct 15, 2019

gen_hash_test.rs was to test asymptotic hash time issues in #132; it's easier to load it up in a profiler to test a very specific case rather than as part of a larger test binary. It doesn't technically need to exist anymore if you'd like to delete it.

@abonander
Copy link
Collaborator

The build failure is due to error message changes on the latest nightly or perhaps a breaking change in trybuild. I can investigate this later if you don't feel like looking into it.

rust-lang/rust#64290 changed that lint output causing test error, however there is no point in keeping this lint stderr
@mati865
Copy link
Contributor Author

mati865 commented Oct 15, 2019

That lint output was changed in rust-lang/rust#64290.
Added empty main function to avoid that lint.

@abonander abonander merged commit 696eee1 into rust-phf:master Oct 15, 2019
@abonander
Copy link
Collaborator

Thanks!

@mati865 mati865 deleted the criterion branch October 15, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants