Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating guide for Rand 0.8 #28

Merged
merged 14 commits into from Dec 18, 2020
Merged

Updating guide for Rand 0.8 #28

merged 14 commits into from Dec 18, 2020

Conversation

vks
Copy link
Contributor

@vks vks commented Aug 31, 2020

This is a first draft. It could be improved by adding external links (to num_traits and std).

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Of course, we're not done yet with 0.8 so should probably wait off merging.

Several comments refer to rand_distr changes, so I suppose we should mention the version numbers for that.

src/update-0.8.md Outdated Show resolved Hide resolved
src/update-0.8.md Outdated Show resolved Hide resolved
src/update-0.8.md Outdated Show resolved Hide resolved
src/update-0.8.md Outdated Show resolved Hide resolved
@dhardy dhardy mentioned this pull request Sep 1, 2020
19 tasks
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vks
Copy link
Contributor Author

vks commented Sep 15, 2020

I added comments about the new SmallRng algorithm and the getrandom update. I think this makes the guide complete for the Rand 0.8 release?

src/update-0.8.md Outdated Show resolved Hide resolved
src/update-0.8.md Outdated Show resolved Hide resolved
@dhardy
Copy link
Member

dhardy commented Dec 16, 2020

Can we mention rust-random/getrandom#178 and rust-random/getrandom#177? They aren't merged yet but whether or not v0.2.1 is out before rand v0.8, we should mention it here.

@dhardy
Copy link
Member

dhardy commented Dec 18, 2020

I'll merge now; we can make a new PR for any fixes.

@dhardy dhardy merged commit 49a77a8 into rust-random:master Dec 18, 2020
@vks vks deleted the update-0.8 branch December 18, 2020 18:38
@dhardy dhardy mentioned this pull request Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants