Avoid require an expression (wasm-bindgen) #138
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using getrandom with Webpack, there is a warning (which is a bit annoying) about using an expression in a
require
callIt turns out this can be avoided by using the
module
attribute on the wasm_bindgen macro. Also the resulting code is a bit simpler and more correct (randomFillSync
is not a method of some crypto class, just a function attached to themodule.exports
object, unlike the browser version, where thegetRandomValues
function is declared in the prototype of the crypto object)