Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport update to cfg-if v1.0 to the v0.1 branch #173

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Backport update to cfg-if v1.0 to the v0.1 branch #173

merged 1 commit into from
Dec 31, 2020

Conversation

newpavlov
Copy link
Member

Requested in #166.

@lopopolo lopopolo mentioned this pull request Nov 23, 2020
Closed
@newpavlov newpavlov requested a review from dhardy December 5, 2020 16:56
@Dragonrun1
Copy link

So this is now the only part of rand crates that is still using the old version of cfg-if. Do we have a timeline when this is getting merged?

@newpavlov
Copy link
Member Author

newpavlov commented Dec 31, 2020 •
edited
Loading

@Dragonrun1
It's blocked on @josephlr approving this PR. Also note that rand v0.8 uses getrandom v0.2 which does not use the old version of cfg-if.

@Dragonrun1
Copy link

Dragonrun1 commented Dec 31, 2020 •
edited
Loading

Actually I just updated to rand 0.8 and was looking with cargo tree and noticed it showing this package still using the old version. If you look at the Cargo.toml on getrandom it still shows cfg-if = "0.1.2" so that kind of why I decided to ask 😉

Edit Just looked and the main branch has been updated to cfg-if = "1" but that's not been push up to crates.io yet.

josephlr
josephlr approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this slip by. Thanks for the backport!

@josephlr josephlr merged commit 15e65a7 into 0.1 Dec 31, 2020
@josephlr josephlr deleted the newpavlov-patch-1 branch December 31, 2020 06:36
@lopopolo lopopolo mentioned this pull request Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

@dhardy dhardy Awaiting requested review from dhardy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@newpavlov @Dragonrun1 @josephlr