Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection for Node JS #215

Merged
merged 1 commit into from
May 20, 2021
Merged

Improve detection for Node JS #215

merged 1 commit into from
May 20, 2021

Commits on May 14, 2021

  1. Imporve detection for Node JS 

    This uses `process.versions.node` to see if we are in Node.js rather
than using `global.self` to check if we are in a Browser.

This change also makes some minor `wasm_bindgen` improvements:
  - Use `js_sys::global()` to get the global object
  - Bind the node require as `module.require`
  - Improving error messages

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2e159d4 View commit details
    Browse the repository at this point in the history