Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI and update runners #324

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Improve CI and update runners #324

merged 8 commits into from
Oct 31, 2022

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Oct 31, 2022 •
edited

As noted in #323 we were broken by the macOS image update. To avoid such things in the future, we:

  • Now use macos-12, ubuntu-22.04, and windows-2022 instead of relying on a generic "latest"
  • For iOS tests, we programatically get the Runtime and Device IDs from XCode, rather than hardcoding these IDs.
    • The runtime is just the first iOS runtime installed
    • The device is just the first (i.e. oldest) iPhone device supported by the runtime
    • So on macOS 12, this is:
      • Runtime: iOS 16
      • Device:iPhone 8
  • We still have to run the Web Tests on Ubuntu 20.04, as the 22.04 image dropped Firefox support (due to the complexity of Firefox packaging on 22.04).
  • This also adds a few minor cleanups around naming and removing workarounds.

The individual changes can be seen in each commit.

@josephlr
Use "host" instead of "target" in Web Tests
8e4ecdb 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Check OS using runner.os instead of matrix.os
5ddec2a 
This makes it easier to later update the OS verions

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Update tests to run on Ubuntu 22.04 (instead of 20.04)
941c2ff 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Remove workaround not needed on Ubuntu 22.04
9d4a91f 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Explicitly use windows-2022
b04bd03 
Currently this is the same as `windows-latest` so this is not a
functional change.

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Run web tests on 20.04
62e697f 
This is necessary to get Firefox to work.

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Programaticly select iOS simulator Runtime/Device
2e66e59 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Update all runners to macOS 12
f096c04 
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr merged commit 759a9d7 into master Oct 31, 2022
@josephlr josephlr deleted the ci branch October 31, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephlr @newpavlov