Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Rustfmt on entire repo #39

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Run Rustfmt on entire repo #39

merged 1 commit into from
Jun 26, 2019

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Jun 26, 2019

This PR keeps allow_failures in the Travis presubmit, we should just run rustfmt from time to time.

@newpavlov
Copy link
Member

Personally I am not sure about removing allow_failures, in my experience it results in a more annoyance than it's worth.

@josephlr
Copy link
Member Author

Personally I am not sure about removing allow_failures, in my experience it results in a more annoyance than it's worth.

I mean all it does is force PRs to be properly formatted when they are submitted. Or is it more a concern about rustfmt's stability?

@newpavlov
Copy link
Member

newpavlov commented Jun 26, 2019

Both, I had experienced CI breakage on my projects due to rustfmt changes, and it will be annoying for contributors who don't use rustfmt. So personally I think it will be better to allow rustfmt failure and fix formatting manually from time to time.

@josephlr
Copy link
Member Author

@newpavlov that makes sense, fixed

@dhardy dhardy merged commit 5c7faa5 into rust-random:master Jun 26, 2019
@josephlr josephlr deleted the rustfmt branch June 26, 2019 20:19
@dhardy dhardy mentioned this pull request Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants