Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Ryzen AMD CPUs have a very serious bug where they will sometimes give
0xFFFFFFFF
as the output of RDRAND without setting the carry flag. This issue usually occurs when those CPU's awake from sleep: systemd/systemd#11810 (comment)This CL simply implement's systemd's fix, where they check for the bogus value and issue an error.
This PR also cleans up the
target_feature
checks. As we already fail to compile onsgx
whenrdrand
is not enabled, theis_rdrand_supported
function checks can just betarget_feature = "rdrand"
.