Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getrandom wrapper func and documentation #7

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Add getrandom wrapper func and documentation #7

merged 4 commits into from
Feb 20, 2019

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Feb 18, 2019

Add a wrapper function for docs and to ensure all platforms have the same API.

Add docs (based on rand_os).

@dhardy dhardy mentioned this pull request Feb 18, 2019
Closed
8 tasks
newpavlov
newpavlov reviewed Feb 18, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
newpavlov
newpavlov reviewed Feb 18, 2019
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using getrandom_inner instead of getrandom_os?

@dhardy
Copy link
Member Author

dhardy commented Feb 18, 2019

We also have syscall_getrandom so perhaps inner makes more sense than os 👍

@dhardy dhardy merged commit 10fdedd into rust-random:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhardy @newpavlov