Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcg: make bincode as dev-dependency #663

Closed
ignatenkobrain opened this issue Dec 11, 2018 · 5 comments
Closed

pcg: make bincode as dev-dependency #663

ignatenkobrain opened this issue Dec 11, 2018 · 5 comments

Comments

@ignatenkobrain
Copy link
Contributor

It is used only from #[test]s, so there is no need to have it in [dependencies].

This would help us a bit in Fedora since we package rust crates there.

@vks
Copy link
Collaborator

vks commented Dec 11, 2018

As far as I can tell, bincode is already a dev dependency:

bincode = { version = "1", features = ["i128"] }

@ignatenkobrain
Copy link
Contributor Author

Oh, I see..

It's just latest released version of pcg on crates.io doesn't have it. Would you mind releasing new version?

@vks
Copy link
Collaborator

vks commented Jan 8, 2019

Sorry for the late reply. This seems to be blocked by bincode-org/bincode#250.

@dhardy
Copy link
Member

dhardy commented Jan 8, 2019

I'd prefer not to tweak this before that issue is fixed because we already had a couple of related issues.

@dhardy
Copy link
Member

dhardy commented Jan 28, 2019

Okay, I made a PR against bincode: bincode-org/bincode#261

Motivation: the current version of PCG still uses rustc_version; it would be nice to get the next release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants