0.19: use of undeclared identifier 'POSIX_MADV_NORMAL'

[kwek20]

Hi!

I am cross compiling rocksdb from WSL to android, which worked in 0.18. (cargo build --target aarch64-linux-android --release)
However when i compile on 0.19 i get the following error:

warning: rocksdb/env/io_posix.cc:1001:41: error: use of undeclared identifier 'POSIX_MADV_NORMAL'
warning:       Madvise(mmapped_region_, length_, POSIX_MADV_NORMAL);
warning:                                         ^
warning: rocksdb/env/io_posix.cc:1004:41: error: use of undeclared identifier 'POSIX_MADV_RANDOM'
warning:       Madvise(mmapped_region_, length_, POSIX_MADV_RANDOM);
warning:                                         ^
warning: rocksdb/env/io_posix.cc:1007:41: error: use of undeclared identifier 'POSIX_MADV_SEQUENTIAL'
warning:       Madvise(mmapped_region_, length_, POSIX_MADV_SEQUENTIAL);
warning:                                         ^
warning: rocksdb/env/io_posix.cc:1010:41: error: use of undeclared identifier 'POSIX_MADV_WILLNEED'
warning:       Madvise(mmapped_region_, length_, POSIX_MADV_WILLNEED);
warning:                                         ^
warning: rocksdb/env/io_posix.cc:1013:41: error: use of undeclared identifier 'POSIX_MADV_DONTNEED'
warning:       Madvise(mmapped_region_, length_, POSIX_MADV_DONTNEED);
warning:                                         ^
warning: 5 errors generated.

Full error: https://pastebin.com/GHRrK3t3

I have traced the error to this commit: 17471a6. (Bump rocksdb to 7.4.3)

I import the crate in the following way:
Broken: rocksdb = { version = "0.19.0", default-features = false, features = [ "lz4" ], optional = true }
Working: rocksdb = { git = "https://github.com/rust-rocksdb/rust-rocksdb", rev = "947e4b63034fff2151f52c399a5d85925ea80911", default-features = false, features = ["lz4"], optional = true }

Any ideas how to fix this?
Thanks!

[samuel-rufi]

Hi, just wanted to note I have run into the same problem when cross compiling for Android on macOS.

[amadeu2]

Hello, I have the same issue on coss compiling for Android.

[aleksuss]

Unfortunately, I don't have such an environment for testing it. Could you provide steps for reproducing it? Besides, you can always create a PR to fix it.

[kwek20]

@aleksuss I have found the issue in rocksdb and made a PR there. Once it is merged ill make a PR here to update rocksdb