Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options.set_filter_deletes calls non-existant RocksDB function #79

Closed
kaedroho opened this issue Oct 27, 2016 · 1 comment
Closed

Options.set_filter_deletes calls non-existant RocksDB function #79

kaedroho opened this issue Oct 27, 2016 · 1 comment

Comments

@kaedroho
Copy link
Contributor

kaedroho commented Oct 27, 2016 •
edited
Loading

Options.set_filter_deletes calls a function in the ffi bindings called rocksdb_options_set_filter_deletes. However, no function of that name is exported by RocksDB itself, leading to a link error (when using static linking).

https://github.com/spacejam/rust-rocksdb/blob/c0e0331d0cb1f652c541d35cebd66de00df26992/src/rocksdb_options.rs#L539
https://github.com/facebook/rocksdb/blob/a10e8a056d569acf6a52045124e6414ad33bdfcd/db/c.cc

Should we remove this method? is there another way to implement it?
@kaedroho
Copy link
Contributor Author

Looks like it was deprecated in 4.10 https://github.com/facebook/rocksdb/blob/master/HISTORY.md#4100-752016

It appears the implementation was removed immediately: facebook/rocksdb@7b79238

@kaedroho kaedroho mentioned this issue Oct 28, 2016
Merged
BusyJay pushed a commit to BusyJay/rust-rocksdb that referenced this issue Jul 7, 2017
@follitude @andelf
Update RocksDB v5.5.1 (rust-rocksdb#79)
5060d53
zhangjinpeng87 pushed a commit to zhangjinpeng87/rust-rocksdb that referenced this issue Apr 19, 2019
Update RocksDB (rust-rocksdb#288)
44d2a52 
Update RocksDB to include the following changes:
018aa1972 Titan: fix error message formatting (rust-rocksdb#84)
ee2f17ca8 Fix crash with memtable prefix bloom and key out of prefix extractor domain (#5190)
16ace7c47 Titan: Add snapshot related test (rust-rocksdb#80)
ee8b59301 Titan: Fix iterator fail to pass SuperVersion to underlying iterator (rust-rocksdb#79)

Signed-off-by: Yi Wu yiwu@pingcap.com
BusyJay pushed a commit to BusyJay/rust-rocksdb that referenced this issue Jul 23, 2020
Update RocksDB (rust-rocksdb#288)
0345d55 
Update RocksDB to include the following changes:
018aa1972 Titan: fix error message formatting (rust-rocksdb#84)
ee2f17ca8 Fix crash with memtable prefix bloom and key out of prefix extractor domain (#5190)
16ace7c47 Titan: Add snapshot related test (rust-rocksdb#80)
ee8b59301 Titan: Fix iterator fail to pass SuperVersion to underlying iterator (rust-rocksdb#79)

Signed-off-by: Yi Wu yiwu@pingcap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaedroho