-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link with system rocksdb and snappy libs through envvars #166
Conversation
Variables: ROCKSDB_LIB_DIR, SNAPPY_LIB_DIR, ROCKSDB_STATIC and SNAPPY_STATIC
@spacejam Sorry for bothering, but can you please give (any) feedback on this? |
Sorry for the huge delay on this! Just started a new job and I've been getting used to a new schedule. I like this approach! I'll cut a new version in a few minutes that includes this change :) |
I've published rocksdb |
@spacejam Thank you! Probably, there will be several more things that we need before switching to your crate, but we are looking forward to that. |
It'd be really neat if EDIT: Or even just a |
Tangentially related to my comment above — this should probably be mentioned in the docs. |
This PR adds 4 env variables:
ROCKSDB_LIB_DIR
,SNAPPY_LIB_DIR
,ROCKSDB_STATIC
andSNAPPY_STATIC
.What do you think of this? :)
(related to #138)