Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with system rocksdb and snappy libs through envvars #166

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

ozkriff
Copy link
Contributor

@ozkriff ozkriff commented Feb 19, 2018

This PR adds 4 env variables: ROCKSDB_LIB_DIR, SNAPPY_LIB_DIR, ROCKSDB_STATIC and SNAPPY_STATIC.

What do you think of this? :)

(related to #138)

Variables: ROCKSDB_LIB_DIR, SNAPPY_LIB_DIR, ROCKSDB_STATIC and SNAPPY_STATIC
@stanislav-tkach
Copy link
Member

I want to add more details: we are currently using fork of rust-rocksdb for our project, but we prefer to switch to your crate. Still we need several things to be done and this is one of them. Thus, we are very interested in any feedback.

@stanislav-tkach
Copy link
Member

@spacejam Sorry for bothering, but can you please give (any) feedback on this?

@spacejam
Copy link
Member

Sorry for the huge delay on this! Just started a new job and I've been getting used to a new schedule. I like this approach! I'll cut a new version in a few minutes that includes this change :)

@spacejam spacejam merged commit 5970844 into rust-rocksdb:master Mar 17, 2018
@spacejam
Copy link
Member

I've published rocksdb 0.10.0 which includes these changes!

@stanislav-tkach
Copy link
Member

@spacejam Thank you! Probably, there will be several more things that we need before switching to your crate, but we are looking forward to that.

@jonhoo
Copy link
Contributor

jonhoo commented May 16, 2018

It'd be really neat if rocksdb-sys checked if rockdb and snappy were available in the standard OS locations too. It's a little unfortunate to have to pass custom environment variables every time we build even though those libraries are installed system-wide.

EDIT: Or even just a ROCKSDB_USE_SYSTEM=1 to link without checking?

@jonhoo
Copy link
Contributor

jonhoo commented May 31, 2019

Tangentially related to my comment above — this should probably be mentioned in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants