Build RocksDB with support for unicode filenames on Windows #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if build failure is caused by this change. I've seen similar things happen using build caching before. I'm guessing it's because of how slow I/O is on WSL, which I think Travis is using. |
|
@udoprog It happens sometime on Travis. I've restarted bad job and It's ok now. |
aleksuss
approved these changes
Jul 23, 2019
ozkriff
approved these changes
Jul 23, 2019
iSynaptic
approved these changes
Jul 23, 2019
vitvakatu
approved these changes
Jul 23, 2019
rleungx
pushed a commit
to rleungx/rust-rocksdb
that referenced
this pull request
Jun 17, 2020
Adding feature "jemalloc". When enabled, rocksdb "WITH_JEMALLOC" will be enabled. This does NOT affect whether jemalloc is use or not. Mostly it only affect how rocksdb calculate block cache size: if "WITH_JEMALLOC" is on, it will use `malloc_usable_size()` (size allocated by jemalloc) to calculate size of each entry of block cache, instead of the requested size of the allocation. Tested by running `cargo build --features jemalloc -vv` and check rocksdb compile flags from the output. Signed-off-by: Yi Wu <yiwu@pingcap.com>
BusyJay
pushed a commit
to BusyJay/rust-rocksdb
that referenced
this pull request
Jul 23, 2020
Cherry-picking the following changes that fixes zlib, jemalloc and gflags dependencies, and fixes a flaky test: ``` 6ead62c 2019-07-25 yiwu@pingcap.com Avoid build require system zlib (rust-rocksdb#303) 9246b9c 2019-07-25 hi@breeswish.org Skip jemalloc options on specific platform (rust-rocksdb#324) 7a8dd73 2019-07-22 yiwu@pingcap.com Add jemalloc-sys dependency when jemalloc is enabled (rust-rocksdb#320) 6f2c632 2019-07-23 yiwu@pingcap.com Not compile with gflags (rust-rocksdb#322) 09b8032 2019-07-22 yiwu@pingcap.com Fix perf context test (rust-rocksdb#321) d67f38e 2019-07-21 yiwu@pingcap.com Add jemalloc feature (rust-rocksdb#319) ``` Also update rocksdb to fix compile error with gcc9: ``` 7a03c83ed 2019-07-23 psergey@askmonty.org Fix MyRocks compile warnings-treated-as-errors on Fedora 30, gcc 9.1.1 (#5553) ```
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes RocksDB to wrap all fs operations using the wide filesystem apis:
https://github.com/facebook/rocksdb/blob/master/port/win/port_win.h#L345
Fixes #85 - even though it's already closed.
This problem was originally punted by RocksDB developers, but a solution that doesn't require a custom environment was merged in October last year.