Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump librocksdb-sys up to 6.11.4 #466

Merged
merged 7 commits into from
Dec 7, 2020

Conversation

aleksuss
Copy link
Member

No description provided.

@aleksuss aleksuss force-pushed the bump_rocksdb_6_11_6 branch 2 times, most recently from 4b03833 to b0d3b18 Compare October 13, 2020 15:11
@stanislav-tkach
Copy link
Member

As far as I can see, there is 6.13.2 version available.

@aleksuss
Copy link
Member Author

aleksuss commented Oct 15, 2020

Yeah. Obviously, it makes sense to update up to 6.13.3.

@aleksuss aleksuss changed the title Bump librocksdb-sys up to 6.11.6 Bump librocksdb-sys up to 6.13.3 Oct 15, 2020
@aleksuss aleksuss changed the title Bump librocksdb-sys up to 6.13.3 Bump librocksdb-sys up to 6.11.4 Dec 7, 2020
@aleksuss aleksuss merged commit e8bb30a into rust-rocksdb:master Dec 7, 2020
@aleksuss aleksuss deleted the bump_rocksdb_6_11_6 branch December 7, 2020 08:07
@@ -3,6 +3,7 @@
## [Unreleased]

* Add `DB::cancel_all_background_work` method (stanislav-tkach)
* Bump `librocksdb-sys` up to 6.13.3 (aleksuss)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused a bit, this bump to 6.11.4 was done in #452 (and is published)
what this PR did is fixed clippy warnings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. You're right. There was some troubles with compilation rocksdb 6.13.3 and therefore I accidentally decreased a version to 6.11.4. Thanks for the notify. I'll bump librocksdb-sys version in near future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, so you've left it out for "future work" :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants