-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building RocksDB with jemalloc #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. But I'd recommend to add a check of this feature to Github Actions CI.
As I can see |
Thanks for taking a look. I converted the PR to a draft for now until I can figure out the best way to handle Windows. |
I tried using the Non-glibc allocator is a must-have for RocksDB on Linux in production. Here is more details on switching to jemalloc http://smalldatum.blogspot.com/2018/04/myrocks-malloc-and-fragmentation-strong.html or other alternative allocator https://blog.cloudflare.com/the-effect-of-switching-to-tcmalloc-on-rocksdb-memory-use/. Note: clippy failing on the CI is unrelated to this PR. It's due to a new Rust release. |
PR #547 resolve clippy warings. |
I'm not sure why the CI fails now, GitHub Actions doesn't show any error output 😕 |
Probably, there was something wrong with CI. I restarted jobs and it's ok now. |
RocksDB includes some optimizations when it's compiled with jemalloc. This PR allows enabling jemalloc using new
jemalloc
feature.