add feature flag for runtime type information, and metadata for locating library and sources #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow dependent crates to easily locate sources (such as rocksdb/include) and libraries built by this crate.
stanislav-tkach
approved these changes
Jul 30, 2021
|
I'm unclear on the approval workflow, and clicked the "Update from master branch" in the Github UI. Unsure if I was supposed to do that 😁 |
aleksuss
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an advanced use case with Estuary Flow where we're interoperating Go and Rust within a single process, and wish to use this crate to actually build RocksDB, while linking it using the
gotoolchain.We've gotten this working by having the
librocksdb-syscrate publish metadata which dependent crates can utilize to locate the RocksDB include sources and the libraries built by this crate.Our use case also requires the RTTI compile-time flag of RocksDB, which is disabled by default. I've added this as a feature flag.