Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive serde::{Serialize, Deserialize} for configuration enums #556

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

thibault-martinez
Copy link
Contributor

@thibault-martinez thibault-martinez commented Sep 20, 2021

This is useful to be able to use them to/from configuration files. At the moment we have to bypass by replicating the enums like https://github.com/iotaledger/bee/blob/coordicide/bee-storage/bee-storage-rocksdb/src/compression.rs.
This is under a feature flag so opt-in and no added dependency by default.

Also remove some warnings in the tests.

Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the really late reply and thanks for the pull request! I think it is a nice improvement and hiding it under the feature is also a good idea.

@thibault-martinez
Copy link
Contributor Author

Hi @stanislav-tkach thanks for the review. I just fixed the CI.

@aleksuss aleksuss merged commit 0548acf into rust-rocksdb:master Nov 18, 2021
@thibault-martinez thibault-martinez deleted the thibault/serde-enums branch November 18, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants