Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make create_new_backup_flush generic #677

Merged
merged 2 commits into from
Sep 1, 2022
Merged

make create_new_backup_flush generic #677

merged 2 commits into from
Sep 1, 2022

Conversation

minshao
Copy link
Contributor

@minshao minshao commented Aug 23, 2022

This allows create_new_backup for OptimisticTransactionDB<T: ThreadMode>.

@MillionIntegrals
Copy link

I just found this issue right now when trying to use BackupEngine with TransactionDB. Is it in any way supported right now?

In the C++ API we have this:

db = txn_db->GetBaseDB();

Which always can be used to get the underlying DB object. Maybe that's all that we need here?

@aleksuss aleksuss merged commit f4b1bd3 into rust-rocksdb:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

@aleksuss aleksuss aleksuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minshao @MillionIntegrals @stanislav-tkach @aleksuss