Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int128 compatibility check(Issue #681) #682

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix int128 compatibility check(Issue #681) #682

merged 1 commit into from
Feb 9, 2023

Conversation

Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Aug 30, 2022

Fix #681

delete 'config.define("HAVE_UINT128_EXTENSION", Some("1"));' in build.rs, which can cause Issue #681

Not all compilers support the type of int128, so the facebook/rocksdb#7338 uses makefile to check int128 compatibility. The type of int128 is not related to target, but related to compiler。

Fix int128 compatibility check (Issue#681)
@stanislav-tkach
Copy link
Member

I'm not sure about simply deleting it. It seems better to enable it conditionally.

@niklasf
Copy link
Contributor

niklasf commented Aug 30, 2022

Definitely agree if there's a good way to feature-detect it. If not, deleting it should be fine. The gains (if there even are any) are pretty minor.

@JEnoch
Copy link

JEnoch commented Dec 9, 2022

Definitely agree if there's a good way to feature-detect it

I think the CARGO_CFG_TARGET_POINTER_WIDTH environment variable could be used in build.rs :
https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts

@niklasf
Copy link
Contributor

niklasf commented Dec 10, 2022

I added this as part of #620 because it was easy to add, without testing if there are actually any advantages to this particular flag. But it turns out there is a clear disadvantage to adding it unconditionally, so I think we should just remove it, i.e., merge this PR.

If someone wants to bring it back later, they can figure out a way to feature-detect this.

@Dirreke
Copy link
Contributor Author

Dirreke commented Dec 11, 2022

Thanks!

@aleksuss aleksuss merged commit 3805d1f into rust-rocksdb:master Feb 9, 2023
romanz pushed a commit to romanz/rust-rocksdb that referenced this pull request Oct 11, 2023
@Dirreke Dirreke deleted the fix-int128-compatibility-check branch November 3, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupport type '__uint128_t' when I used arm-linux-gnueabihf
5 participants